To put it bluntly I have no clue why I should use private classes and yet in this revision of a game we made earlier in the year we have to use public and private classes.

Public I get, private I don't

So I'd appreciate it if someone would either A.) be willing to help me with this program. Or B.) Explain why I should use them and a bit of how to

Get ready for lazy coding!!!!
Tic tac Toe BTW

Code:

#include <iostream> #include <time.h> #include <stdio.h> #include <stdlib.h> using namespace std; class board{     private:         int iRw;         int iCl;     public:         const int iRow(){return iRw;}         const int iCol(){return iCl;}         void set_values (int, int);         char hold[100]; // used to stop the program from closing or as a replacement for the system pause command         char cJunk;         int iRowI; // row input         int iColI; // column imput }; void board::set_values (int a, int b){     iRw = a;     iCl = b; } int main() { board brd; brd.set_values (3,3); cout << brd.iRow() << endl; char board[brd.iCol()][brd.iRow()];  for(int row = 0; row < brd.iRow(); row++)     {         for(int col = 0; col < brd.iCol(); col++)         {         board[col][row] = '#'; // What the board tokens will look like         }     } int c = 1; int d = 2; while (c < d){ // Here we enter the game loop cout << "Would you like to play tic-tac-toe?"             << endl; cout << "if so, press enter, if not then close this out." << endl; cin.getline(brd.hold, 10);     int e = 1;     int f = 2;         while ( e < f ) {             e = 1;             f = 2; // End of board stuff // Player 1 is opted to go     for(int row = 0; row < brd.iRow(); row++)     {         cout << "               ";         for(int col = 0; col < brd.iCol(); col++)         {             brd.cJunk= board[col][row];                 cout << " |_ " << brd.cJunk << " _| ";         }         cout << endl;         cout << endl;     } int e = 0; int f = 1; while ( e < f ) {  cout << "Player 1, go. Enter a row, hit enter, then enter a column and hit enter" << endl;  cout << "Column: ";  cin  >> brd.iColI;  cout << "Row: ";  cin  >> brd.iRowI; board[brd.iColI][brd.iRowI] = 'X'; brd.cJunk = board[brd.iRowI][brd.iColI];     for(int row = 0; row < brd.iRow(); row++)     {         cout << "               ";         for(int col = 0; col < brd.iCol(); col++)         {             brd.cJunk = board[col][row];                 cout << " |_ " << brd.cJunk << " _| ";         }         cout << endl;         cout << endl;     } cout << "Player 2 go" << endl;  cout << "Column: ";  cin  >> brd.iColI;   cout << "Row: ";  cin  >> brd.iRowI; board[brd.iColI][brd.iRowI] = 'O'; brd.cJunk = board[brd.iColI][brd.iRowI];     for(int row = 0; row < brd.iRow(); row++)     {         cout << "               ";         for(int col = 0; col < brd.iCol(); col++)         {             brd.cJunk = board[col][row];                 cout << " |_ " << brd.cJunk << " _| ";         }         cout << endl;         cout << endl;     } cout << endl; cout << endl; } } // End of game loop         } cin.getline(brd.hold, 1); return 0; }

Douche McCallister wrote:

I now understand why my professor always told us to make the variables something relevant or write comments. ---------------------------------- int e = 0; int f = 1; while ( e < f ) { ... Whats the purpose of this? Doesn't this result in a infinite loop since the code never increments "e"?

Yeah it results in an infinite loop that can be modified later.
if I were to do
e = 2;
later in the code it would exit the loop.
The purpose for that loop is so the board won't reinitialize
The codes close to being finished but I still have quite a bit to work with

Ah okay, that helps

Here's an updated version of my code
Now it dies at a certain point >_<
--------------------------

#include <iostream>
#include <time.h>
#include <stdio.h>
#include <stdlib.h>

using namespace std;

class board{
private:
static const int iMAX = 3;

int iRowI; // row input
int iColI; // column input

public:
int iMAXI(){return iMAX;}
void set_values (int, int);
char hold[100];

char cJunk;
int set_row(int iX)
{
iRowI = iX;
return 0;
}
int set_col(int iY)
{
iColI = iY;
return 0;
}
int get_col()
{
return iColI;
}
int get_row()
{
return iRowI;
}
int input_int()
{
int iTemp;
cin >> iTemp;
return iTemp;
}
};



int main()
{
board brd;

cout << " " << "Tic Tac Toe " << brd.iMAXI() << " in a row." << endl;
cout << endl;
char board[brd.iMAXI()][brd.iMAXI()];

for(int row = 0; row < brd.iMAXI(); row++)
{
for(int col = 0; col < brd.iMAXI(); col++)
{

board[col][row] = '#'; // What the board tokens will look like

}
}

int c = 1;
int d = 2;

while (c < d){ // Here we enter the game loop

cout << "Would you like to play tic-tac-toe?" << endl;
cout << "if so, press enter, if not then close this out." << endl;
cin.getline(brd.hold, 10);


int e = 1;
int f = 2;

while ( e < f ) {
e = 1;
f = 2;


// End of board stuff
// Player 1 is opted to go

for(int row = 0; row < brd.iMAXI(); row++)
{
cout << " ";
for(int col = 0; col < brd.iMAXI(); col++)
{
brd.cJunk = board[col][row];

cout << " |_ " << brd.cJunk << " _| ";

}

cout << endl;
cout << endl;
}

int e = 0;
int f = 1;
// right now we enter a loop so the board can't be reinitialized and thus reset
while ( e < f ) {

cout << "Player 1, go. Enter a row, hit enter, then enter a column and hit enter" << endl;

cout << "Column: ";
brd.set_row(brd.input_int());

cout << "Row: ";
brd.set_row(brd.input_int());

board[brd.get_col()][brd.get_row()] = 'X'; // <---- DIES RIGHT HERE!!!!
brd.cJunk = board[brd.get_col()][brd.get_row()];

for(int row = 0; row < brd.iMAXI(); row++)
{
cout << " ";
for(int col = 0; col < brd.iMAXI(); col++)
{
brd.cJunk = board[col][row];

cout << " |_ " << brd.cJunk << " _| ";

}
cout << endl;
cout << endl;
}



cout << "Player 2 go" << endl;

cout << "Column: ";
brd.set_row(brd.input_int());

cout << "Row: ";
brd.set_row(brd.input_int());

board[brd.get_col()][brd.get_row()] = 'O';
brd.cJunk = board[brd.get_col()][brd.get_row()];

for(int row = 0; row < brd.iMAXI(); row++)
{
cout << " ";
for(int col = 0; col < brd.iMAXI(); col++)
{
brd.cJunk = board[col][row];

cout << " |_ " << brd.cJunk << " _| ";

}
cout << endl;
cout << endl;
}


cout << endl;
cout << endl;

}


}
// End of game loop
}

cin.getline(brd.hold, 1);
return 0;
}
----------------------------

That was crap my teacher added.

All the data functions have to be private.
He told me it's unnecessary but that's how he wants it

iMAXI creates the number 3. to replace all the const int's I had that were 3

cJunk is essentially what becomes the board

as for the a b c d ETC.

That's all because right now I just need a base system, I'll fine tune it once I get it to run.

Which is what I need help with right now

iX and iY are being thrown in with int set_row and int set_col

and I am using a character array for the board.
Where I'm telling it to make the input the character 'X' is where it dies.

And that was after my teacher messed with it

I had it as a simple cin >> thing
Then my teacher said I can't do that for your project and that all the data members need too be in the private class so he wrote up the get_whatever crap.

His assignment is to make tic tac toe
With all the data members being in the private class
and all the code in the public

He was a software designer by profession. This is his first year teaching

This is the input for the row and column

cout << "Column: ";
brd.set_row(brd.input_int()); <--- input

cout << "Row: ";
brd.set_row(brd.input_int()); <---- input


The input is then stored with the set_row or set_col

int set_row(int iX)
{
iRowI = iX;
return 0;
}

It takes the input, turns it into iX (or iY for column) and then turns it into iRowI (or iColI)

then with this it's called into the int main()
brd.get_col()

board[brd.get_col()][brd.get_row()] = 'X';
That above is the line that causes the program to fail.
I'm trying to assign the inputted numbers as 'X'

now when I had it as this

Code:

#include <iostream> #include <time.h> #include <stdio.h> #include <stdlib.h> using namespace std; class board{     private:         int iRw;         int iCl;     public:         const int iRow(){return iRw;}         const int iCol(){return iCl;}         void set_values (int, int);         char hold[100];         char cJunk;         int iRowI; // row input         int iColI; // column imput }; void board::set_values (int a, int b){     iRw = a;     iCl = b; } int main() { board brd; brd.set_values (3,3); cout << brd.iRow() << endl; char board[brd.iCol()][brd.iRow()];  for(int row = 0; row < brd.iRow(); row++)     {         for(int col = 0; col < brd.iCol(); col++)         {         board[col][row] = '#'; // What the board tokens will look like         }     } int c = 1; int d = 2; while (c < d){ // Here we enter the game loop cout << "Would you like to play tic-tac-toe?"             << endl; cout << "if so, press enter, if not then close this out." << endl; cin.getline(brd.hold, 10);     int e = 1;     int f = 2;         while ( e < f ) {             e = 1;             f = 2; // End of board stuff // Player 1 is opted to go     for(int row = 0; row < brd.iRow(); row++)     {         cout << "               ";         for(int col = 0; col < brd.iCol(); col++)         {             brd.cJunk= board[col][row];                 cout << " |_ " << brd.cJunk << " _| ";         }         cout << endl;         cout << endl;     } int e = 0; int f = 1; while ( e < f ) {  cout << "Player 1, go. Enter a row, hit enter, then enter a column and hit enter" << endl;  cout << "Column: ";  cin  >> brd.iColI;  cout << "Row: ";  cin  >> brd.iRowI; board[brd.iColI][brd.iRowI] = 'X'; brd.cJunk = board[brd.iRowI][brd.iColI];     for(int row = 0; row < brd.iRow(); row++)     {         cout << "               ";         for(int col = 0; col < brd.iCol(); col++)         {             brd.cJunk = board[col][row];                 cout << " |_ " << brd.cJunk << " _| ";         }         cout << endl;         cout << endl;     } cout << "Player 2 go" << endl;  cout << "Column: ";  cin  >> brd.iColI;   cout << "Row: ";  cin  >> brd.iRowI; board[brd.iColI][brd.iRowI] = 'O'; brd.cJunk = board[brd.iColI][brd.iRowI];     for(int row = 0; row < brd.iRow(); row++)     {         cout << "               ";         for(int col = 0; col < brd.iCol(); col++)         {             brd.cJunk = board[col][row];                 cout << " |_ " << brd.cJunk << " _| ";         }         cout << endl;         cout << endl;     } cout << endl; cout << endl; } } // End of game loop         } cin.getline(brd.hold, 1); return 0; }

Everything worked fine.
Even that above was unnecessary, but he told me it was wrong and then changed crap then told me to change more crap and it stopped working.
All in the name of an unnecessary way of coding -_-[/code]

I'm thinking it may be time to rewrite this thing entirely

Apparently not
brd.set_row(brd.input_int()); <------ this runs

int input_int()
{
int iTemp;
cin >> iTemp; <------- this
return iTemp;
}
which in turn is read by
brd.set_row() <------ this

It's an unnecessary way of saying

cin >> iRowI;

which I can't do because iRowI is private.
Because that's how he wants it >_<

I should mention he also wants the main code in the public class
And thanks douche

I got it working